Hi,
On Thu, Dec 14, 2017 at 1:38 PM, Alexander Aring <ar...@mojatatu.com> wrote:
> This patch adds extack support for generic qdisc handling. The extack
> will be set deeper to each called function which is not part of netdev
> core api.
>
> Cc: David Ahern <dsah...@gmail.com>
> Signed-off-by: Alexander Aring <ar...@mojatatu.com>
> ---
> net/sched/sch_api.c | 159
> ++++++++++++++++++++++++++++++++++++----------------
> 1 file changed, 112 insertions(+), 47 deletions(-)
>
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index b54917f4ad87..3ff59433781b 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -449,7 +449,8 @@ static const struct nla_policy stab_policy[TCA_STAB_MAX +
> 1] = {
> [TCA_STAB_DATA] = { .type = NLA_BINARY },
> };
>
> -static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt)
> +static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt,
> + struct netlink_ext_ack *extack)
> {
...
> sch = qdisc_alloc(dev_queue, ops);
> - if (IS_ERR(sch)) {
> + if (IS_ERR(sch))
> err = PTR_ERR(sch);
> goto err_out2;
> - }
>
sorry, I detect this now. brackets should still be there. Happens in
some rebase foo stuff v1, didn't contained handling of extack in this
function...
I will send v3.
- Alex
