From: Russell King <rmk+ker...@armlinux.org.uk> Date: Wed, 13 Dec 2017 09:22:09 +0000
> @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device > *phydev) > err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); > if (err < 0) > return err; > + > + /* There appears to be a bug in the 88e1512 when used in > + * SGMII to copper mode, where the AN advertisment register > + * clears the pause bits each time a negotiation occurs. > + * This means we can never be truely sure what was advertised, > + * so disable Pause support. > + */ > + pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; > + phydev->supported &= ~pause; > + phydev->advertising &= ~pause; > } > This function doesn't have a local 'pause' variable in any of my trees. I wonder what you generated this against, and even more importantly, what tree the reviewers were considering when looking at this patch :)
