On 12/08/2017 07:48 AM, Russell King wrote: > Add unlocked versions of the bus accessors, which allows access to the > bus with all the tracing. These accessors validate that the bus mutex > is held, which is a basic requirement for all mii bus accesses. > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > --- > include/linux/phy.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 71d777fe6c3d..964803bd7324 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -716,6 +716,18 @@ static inline int phy_read(struct phy_device *phydev, > u32 regnum) > } > > /** > + * __phy_read - convenience function for reading a given PHY register > + * @phydev: the phy_device struct > + * @regnum: register number to read > + * > + * The caller must have taken the MDIO bus lock. > + */ > +static inline int __phy_read(struct phy_device *phydev, u32 regnum) Do you know if we could have sparse validate that the caller of these functions holds the mutex? I remember reading somewhere that sparse does not do that yet, but can't get my hands on it. -- Florian
