Re: [PATCH] slip: sl_alloc(): remove unused parameter "dev_t line"

[Oliver Hartkopp]

On 12/08/2017 12:22 PM, Marc Kleine-Budde wrote:

Hello Oliver,

I've the corresponding slcan patch already in my queue.

Excellent :-)

Thanks,
Oliver

Marc

On 12/08/2017 12:18 PM, Marc Kleine-Budde wrote:

The first and only parameter of sl_alloc() is unused, so remove it.

Fixes: 5342b77c4123 slip: ("Clean up create and destroy")
Signed-off-by: Marc Kleine-Budde <m...@pengutronix.de>
---
  drivers/net/slip/slip.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
index cc63102ca96e..8940417c30e5 100644
--- a/drivers/net/slip/slip.c
+++ b/drivers/net/slip/slip.c
@@ -731,7 +731,7 @@ static void sl_sync(void)

/* Find a free SLIP channel, and link in this `tty' line. */

-static struct slip *sl_alloc(dev_t line)
+static struct slip *sl_alloc(void)
  {
        int i;
        char name[IFNAMSIZ];
@@ -809,7 +809,7 @@ static int slip_open(struct tty_struct *tty)

/* OK. Find a free SLIP channel to use. */

        err = -ENFILE;
-       sl = sl_alloc(tty_devnum(tty));
+       sl = sl_alloc();
        if (sl == NULL)
                goto err_exit;