On Fri, Dec 08, 2017 at 11:40:23AM +0800, Yafang Shao wrote: > It will looks like these, > > if (sk->sk_protocol == IPPROTO_TCP) > __tcp_set_state(newsk, TCP_SYN_RECV); > else > newsk->sk_state = TCP_SYN_RECV; > > > if (sk->sk_protocol == IPPROTO_TCP) > __tcp_set_state(sk, TCP_CLOSE); > else > sk->sk_state = TCP_CLOSE; > > if (sk->sk_protocol == IPPROTO_TCP) > tcp_state_store(sk, state); > else > sk_state_store(sk, state); > > > Some redundant code. > > IMO, put these similar code into a wrapper is more nice.
Agreed. Hmpf, looks like one way or another, we have to add the sk_ functions to do such check, and then the tcp_* won't help much. I'm okay with this v5 then, can't see a better way around it. Marcelo
