Hi David! >> +#define pci_reg_control6_adr 0x1014u >> + > CPP macros, especially those which define register numbers or bit > valus, should never use lowercase. They should always use uppercase > names. > > This is a coding style convention we use in the entire kernel which > makes it easy to visually see whether something is a bonafide C > symbol or a CPP macro.
Totally agree on that. I honestly not aware of the history why it was done in lowercase. I'm now preparing a set of commits for new hardware revisions support, I can queue this task there as well. Or, if you prefer, I may add this low to uppercase conversion patch into this patchset and resubmit. BR, Igor
