[PATCH net-next v2 3/5] net: dsa: mv88e6xxx: setup global upstream port

[Vivien Didelot]

Move the setup of the global upstream port within the
mv88e6xxx_setup_upstream_port function.

Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 77488b40cceb..e1c0bb24f5b2 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1758,6 +1758,22 @@ static int mv88e6xxx_setup_upstream_port(struct 
mv88e6xxx_chip *chip, int port)
                        return err;
        }
 
+       if (port == upstream_port) {
+               if (chip->info->ops->set_cpu_port) {
+                       err = chip->info->ops->set_cpu_port(chip,
+                                                           upstream_port);
+                       if (err)
+                               return err;
+               }
+
+               if (chip->info->ops->set_egress_port) {
+                       err = chip->info->ops->set_egress_port(chip,
+                                                              upstream_port);
+                       if (err)
+                               return err;
+               }
+       }
+
        return 0;
 }
 
@@ -1959,21 +1975,8 @@ static int mv88e6xxx_set_ageing_time(struct dsa_switch 
*ds,
 static int mv88e6xxx_g1_setup(struct mv88e6xxx_chip *chip)
 {
        struct dsa_switch *ds = chip->ds;
-       u32 upstream_port = dsa_upstream_port(ds);
        int err;
 
-       if (chip->info->ops->set_cpu_port) {
-               err = chip->info->ops->set_cpu_port(chip, upstream_port);
-               if (err)
-                       return err;
-       }
-
-       if (chip->info->ops->set_egress_port) {
-               err = chip->info->ops->set_egress_port(chip, upstream_port);
-               if (err)
-                       return err;
-       }
-
        /* Disable remote management, and set the switch's DSA device number. */
        err = mv88e6xxx_g1_write(chip, MV88E6XXX_G1_CTL2,
                                 MV88E6XXX_G1_CTL2_MULTIPLE_CASCADE |
-- 
2.15.1