On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off >> hardware GRO based on NETIF_F_GRO_HW. > > So the patch only deals with advertisement biz.. and I even failed to > find a place where you arm > something in the FW... so this just works OOB, all your buffers && skb > logic && FW setup are fully > ready for that? also, nothing you need to put differently on the SKB > for HW GRO completions? > can you explain this little further or it's all in your netdev slides... >
All the logic is already in these 3 drivers in the tree. You can see the additional logic in any of these drivers. It's just that these drivers have been using NETIF_F_GRO to turn on this mode in hardware/firmware. So these patches are just to switch over to use the new flag to turn on this mode so that it can be independently turned on or off.
