On 11/28/2017 07:37 AM, Madalin-cristian Bucur wrote: >> -----Original Message----- >> From: Andrew Lunn [mailto:and...@lunn.ch] >> Sent: Tuesday, November 28, 2017 4:13 PM >> To: Madalin-cristian Bucur <madalin.bu...@nxp.com> >> Subject: Re: [RFC] Support for SGMII 2500 >> >>> Hi Andrew, >>> >>> Bhaskar is working on enabling a PFE [1] MAC connected to an Aquantia >> AQR107 >>> PHY [2] on a LS1012AQDS board. Initially I've indicated 2500Base-X too, >> but it >>> seems the HW actually works in SGMII mode. The QDS boards are lower >> volume, >>> higher spec boards than the RDBs [3], they exercise most of the HW >> capabilities. >> >> The webpage for the AQR107 lists 2500Base-X, so i assume the issue is >> with the MAC? Ideally you want to use 2500Base-X, since this is wider >> known. >> >> Anyway, you seem to have a legitimate need for it. >> >> However, i would prefer a different name. The convention is to put the >> number first. So PHY_INTERFACE_MODE_2500SGMII. >> >> Andrew > > OK, > > I just wanted to make sure 2.5G SGMII is to be added separately from the > "normal" SGMII, as it was done in u-boot. Thanks also for the naming hint.
Sorry for chiming in that late, but what is 2.5G SGMII exactly? Either you can use SGMII auto-negotiation, and in which case, why is not 2.5G selected, or you can't and you might want to use a fixed-link property then. -- Florian
