From: Heiner Kallweit <hkallwe...@gmail.com>
Date: Sun, 19 Nov 2017 01:36:02 +0100

> diff --git a/drivers/net/ethernet/realtek/r8169.c 
> b/drivers/net/ethernet/realtek/r8169.c
> index 19f3074a0..912549c88 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -3810,6 +3810,11 @@ static void rtl8168e_2_hw_phy_config(struct 
> rtl8169_private *tp)
>       rtl_w0w1_phy(tp, 0x19, 0x0001, 0x0000);
>       rtl_w0w1_phy(tp, 0x10, 0x0400, 0x0000);
>       rtl_writephy(tp, 0x1f, 0x0000);
> +     rtl_writephy(tp, 0x1f, 0x0005);
> +     rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
> +     rtl_writephy(tp, 0x1f, 0x0000);
> +     /* soft-reset phy */
> +     rtl_writephy(tp, 0x00, 0x9200);

Please do not use magic constants when writing to the MII_BMCR in page
zero of the PHY.  These register offsets and register bit fields have
defines in <linux/mii.h", so please use them.

Reply via email to