Hi Dave, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dave-Taht/netem-convert-to-qdisc_watchdog_schedule_ns/20171111-184934 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): In file included from ./arch/xtensa/include/generated/asm/div64.h:1:0, from include/linux/kernel.h:173, from include/asm-generic/bug.h:16, from ./arch/xtensa/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:9, from net/sched/sch_netem.c:16: net/sched/sch_netem.c: In function 'packet_len_2_sched_time': include/asm-generic/div64.h:208:28: warning: comparison of distinct pointer types lacks a cast (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ ^ >> net/sched/sch_netem.c:349:2: note: in expansion of macro 'do_div' do_div(offset, q->rate); ^ vim +/do_div +349 net/sched/sch_netem.c 334 335 static s64 packet_len_2_sched_time(unsigned int len, 336 struct netem_sched_data *q) 337 { 338 s64 offset; 339 len += q->packet_overhead; 340 341 if (q->cell_size) { 342 u32 cells = reciprocal_divide(len, q->cell_size_reciprocal); 343 344 if (len > cells * q->cell_size) /* extra cell needed for remainder */ 345 cells++; 346 len = cells * (q->cell_size + q->cell_overhead); 347 } 348 offset = (s64)len * NSEC_PER_SEC; > 349 do_div(offset, q->rate); 350 return offset; 351 } 352 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
