On Wed, 2017-11-08 at 23:13 +0900, Or Gerlitz wrote:
> On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed <sae...@mellanox.com>
> wrote:
> > From: Kamal Heib <kam...@mellanox.com>
> >
> > In the current code, if a size of zero is passed to
> > mlx5_fpga_mem_{read|write}_i2c() functions the "err"
>
> Don't we need to fix the call site where zero size is provided and
> not
> in called function?
>
Isn't sending down a zero size a sign for a bug which we are not
fixing?
>
Both functions are called from an exported symbols. so I think the size
validation should be within this two functions just like the case of
checking that mdev isn't set.
> > return value will not initialized.
> >
> > Fixes: a9956d35d199 ('net/mlx5: FPGA, Add SBU infrastructure')
> > Signed-off-by: Kamal Heib <kam...@mellanox.com>
> > Reviewed-by: Yevgeny Kliteynik <klit...@mellanox.com>
> > Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
