On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote: > Create separate enumerations for the SFP physical state (computed from GPIOs), > device state, module state, and actual state machine. This will make it easier > to make sure the correct states are used, and also pretty print those to help > debugging.
The compiler does no type checking of these, so I don't see how it makes it any "easier to make sure the correct states are used". -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
