On Mon, Nov 06, 2017 at 09:41:09AM -0800, Linus Torvalds wrote: > On Mon, Nov 6, 2017 at 9:27 AM, Linus Torvalds > <torva...@linux-foundation.org> wrote: > > > > Lovely. This is great. It shows just how much totally pointless stuff > > we leak, and to normal users that really shouldn't need it. > > Side note: it would be good to have some summary view, and perhaps > some way to limit duplicates.
This has been bothering me also. > I ended up running this command line from hell to summarize the > different sources: > > perl leaking_addresses.pl | > cut -d: -f1 | > sed 's:/[0-9]*/:/X/:g' | > sed 's:/module/[^/]*/:/module/X/:g' | > sort | uniq | less -S > > and maybe that kind of duplicate culling could be part of the script > itself if you pass it some summary line. > > In particular, if would be nice to have a summary report that > > - only shows the first address for a particular source > > - have some logic to collapse repeated entries of "same file, just > different instance" > > my sed-invocations there are obviously very ad-hoc, I'm not actually > advocating that crap, it's only meant as hacky example of what I'm > talking about. Something smarter would be much better. > > Because right now if some developer runs it, they might miss some case > that they should care about, simply because it's hidden among all the > thousands of essentially duplicate cases. Awesome. I'm on it. thanks. So, cull duplicates by default, add summary report to end of output, add '--raw' option to dump all the lines (the current output). thanks, Tobin.
