On Fri, 3 Nov 2017 11:50:25 -0400
Manish Kurup <kurup.man...@gmail.com> wrote:
> Modified netronome nfp flower action to use VLAN helper functions instead
> of accessing the structure directly.
>
> Signed-off-by: Manish Kurup <manish.ku...@verizon.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/action.c
> b/drivers/net/ethernet/netronome/nfp/flower/action.c index de64ced..c1c595f
> 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/action.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/action.c
> @@ -58,7 +58,6 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
> const struct tc_action *action)
> {
> size_t act_size = sizeof(struct nfp_fl_push_vlan);
> - struct tcf_vlan *vlan = to_vlan(action);
> u16 tmp_push_vlan_tci;
>
> push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN;
> @@ -67,8 +66,8 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
> push_vlan->vlan_tpid = tcf_vlan_push_proto(action);
>
> tmp_push_vlan_tci =
> - FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
> - FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
> + FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO,
> tcf_vlan_push_prio(action)) |
> + FIELD_PREP(NFP_FL_PUSH_VLAN_VID, tcf_vlan_push_vid(action))
> | NFP_FL_PUSH_VLAN_CFI;
> push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
> }
Thank you for this; you may consider this patch:
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com>
