On Mon, 6 Nov 2017 11:52:37 -0500 Manish Kurup <kurup.man...@gmail.com> wrote:
> Hi Dave, > > On Sun, Nov 5, 2017 at 8:08 AM, David Miller <da...@davemloft.net> wrote: > > > From: Manish Kurup <kurup.man...@gmail.com> > > Date: Fri, 3 Nov 2017 11:49:19 -0400 > > > > > Modified the netronome drivers (flower action) to use the VLAN helper > > > functions instead of dereferencing the structure directly. This is > > > required for the VLAN action patch. > > > > > > Could you please review? > > > > Please use a more appropriate patch series header posting than this. > > > > This subject shall describe what the patch series is about, in much > > the same style as a normal commit, using appropriate subsystem > > prefixes and so on. > > > > The commit message body must describe what the patch series is doing, > > how it is doing it, and why it is doing it that way. > > > > Mistakenly unicasted my reply (below) to Dave. > > Currently, the body of the commit message describes what it is doing in > each commit patch. Would you like me to add some detail to the > description of each commit? Hi Manish, Your patch series header is "Incorporated all required changes", could you update this to something more descriptive?