On Fri, 18 August 2006 15:25:11 +0200, Thomas Klein wrote: > Arjan van de Ven wrote: > >>+ queue->queue_length = nr_of_pages * pagesize; > >>+ queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *)); > > > > > >wow... is this really so large that it warrants a vmalloc()??? > > Agreed: Replaced with kmalloc()
kzalloc() and you can remove the memset() as well. Jörn -- Data dominates. If you've chosen the right data structures and organized things well, the algorithms will almost always be self-evident. Data structures, not algorithms, are central to programming. -- Rob Pike - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
