Hi Andrew, On 01.11.2017 13:16, Andrew Lunn wrote: >> @@ -123,6 +153,10 @@ int phy_led_triggers_register(struct phy_device *phy) >> while (i--) >> phy_led_trigger_unregister(&phy->phy_led_triggers[i]); >> devm_kfree(&phy->mdio.dev, phy->phy_led_triggers); >> +out_unreg_link: >> + phy_led_trigger_unregister(phy->led_link_trigger); >> +out_free_link: >> + devm_kfree(&phy->mdio.dev, phy->led_link_trigger); > > Hi Maciej > > The point of the devm_ API is that you don't need to worry about > freeing the memory. The core will do it, when the driver is removed. > > I guess you are just copying the code above, which i would also say is > unnecessary.
Yes, I did it the same way as the existing code did for phy->phy_led_triggers for reasons of both consistency and also to be on the safe side because maybe there is some non-obvious reason why it has to be freed explicitly (?). > Andrew Maciej
