Wed, Nov 01, 2017 at 03:17:31AM CET, [email protected] wrote: >Now that SK_REDIRECT is no longer a valid return code. Remove it >from the UAPI completely. Then do a namespace remapping internal >to sockmap so SK_REDIRECT is no longer externally visible. > >Patchs primary change is to do a namechange from SK_REDIRECT to >__SK_REDIRECT > >Reported-by: Alexei Starovoitov <[email protected]> >Signed-off-by: John Fastabend <[email protected]> >--- > include/uapi/linux/bpf.h | 1 - > kernel/bpf/sockmap.c | 16 ++++++++++++---- > tools/include/uapi/linux/bpf.h | 3 +-- > 3 files changed, 13 insertions(+), 7 deletions(-) > >diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >index 0d7948c..7bf4c75 100644 >--- a/include/uapi/linux/bpf.h >+++ b/include/uapi/linux/bpf.h >@@ -788,7 +788,6 @@ struct xdp_md { > enum sk_action { > SK_DROP = 0, > SK_PASS, >- SK_REDIRECT,
Is it really ok to do uapi changes like this?
