> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, October 30, 2017 2:20 PM > To: j...@resnulli.us > Cc: netdev@vger.kernel.org; Nogah Frankel <nog...@mellanox.com>; > j...@mojatatu.com; > xiyou.wangc...@gmail.com; mlxsw <ml...@mellanox.com>; and...@lunn.ch; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; > michael.c...@broadcom.com; > ganes...@chelsio.com; Saeed Mahameed <sae...@mellanox.com>; Matan Barak > <mat...@mellanox.com>; Leon Romanovsky <leo...@mellanox.com>; Ido Schimmel > <ido...@mellanox.com>; jakub.kicin...@netronome.com; > simon.hor...@netronome.com; > pieter.jansenvanvuu...@netronome.com; john.hur...@netronome.com; > alexander.h.du...@intel.com; Or Gerlitz <ogerl...@mellanox.com>; > john.fastab...@gmail.com > Subject: Re: [patch net-next RFC 1/9] net_sch: red: Add offload ability to > RED qdisc > > From: Jiri Pirko <j...@resnulli.us> > Date: Mon, 30 Oct 2017 09:56:05 +0100 > > > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > > index 0e88cc2..743c42a 100644 > > --- a/include/uapi/linux/pkt_sched.h > > +++ b/include/uapi/linux/pkt_sched.h > > @@ -255,6 +255,7 @@ struct tc_red_qopt { > > #define TC_RED_ECN 1 > > #define TC_RED_HARDDROP 2 > > #define TC_RED_ADAPTATIVE 4 > > +#define TC_RED_OFFLOADED 8 > > }; > > > > struct tc_red_xstats { > > What keeps a user from setting this flag in the tc_red_qopt it > passes into the a change operation?
Nothing keeps the user from doing it, but it has no effect. The decision to offload is the driver's only. It is basically a read-only flag.
