> The DSA code currently has 3 bitmaps in the dsa_switch structure: > cpu_port_mask, dsa_port_mask and enabled_port_mask.
Hi Vivien First I must apologize to everybody for not replying in-thread. Problem is that I was not subscribed to netdev. But now I am, so I promise it will not happen again :-) So to the point. I think DSA need to keep track of multicast memberships. As it is now, dsa_switch_mdb_add() include the CPU/DSA port(s) in the multicast. But multicast is never removed from the CPU/DSA port(s). One option could be that DSA remember mulitcast memberships as bitmaps of ports. Then it could be handy to have the CPU and DSA ports as bitmaps too. It might not fall out that way in the end. But anyway, my suggestion is: Do patch 1 - 6, which isolates the drivers from the internal structure of dsa. But hold on to 7 - 9 until there is a plan for better multicast handling in DSA. BR Egil
