On Mon, Oct 23, 2017 at 09:24:04AM -0700, Jakub Kicinski wrote: > Quentin says: > > This series introduces support for JSON output to all bpftool commands. It > adds option parsing, and several options are created: > > * -j, --json Switch to JSON output. > * -p, --pretty Switch to JSON and print it in a human-friendly fashion. > * -h, --help Print generic help message. > * -V, --version Print version number. > > This code uses a "json_writer", which is a copy of the one written by > Stephen Hemminger in iproute2. > --- > I don't know if there is an easy way to share the code for json_write > without copying the file, so I am very open to suggestions on this matter.
I think copy-paste is fine in this case. If we ever decide to remove it from here and move it into iproute2 this json.[hc] can be unified, but I think kernel/tools/bpf/ is a better place since introspection interface is still evolving a lot and bpftool is not networking specific. Like would be great if it can show what programs attached to which cgroups, tracepoints, kprobes. Overall looks like a nice set of improvements. Acked-by: Alexei Starovoitov <a...@kernel.org>
