Hi Thomas: On Wed, Aug 16, 2006 at 12:58:56PM +0200, Thomas Graf wrote: > > All route and tc notifications already use the pid so applications > can decide whether the event was caused by them. A notification > is a reply to a request so it doesn't even violate RFC 2367.
Actually most IPv4 notifications *do* set the pid to zero which is the right thing to do for kernel-generated messages. You're right though that the IPv6 notification modified by this patch does set the pid to the netlink originator. Looking back in history it seems that this behaviour was only introduced last year to a subset of notifications. This inconsistency is very bad. IMHO this change (made last year) should be reverted so that all kernel generated (broadcast) notifications have the originator set to zero to match the source address of the message. Any notification that sets the netlink pid to current->pid is *completely* bogus. Let me repeat this, the netlink pid is not a process ID. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
