Hi David, Woojung, woojung....@microchip.com writes:
>> From: Vivien Didelot >> > Sent: 13 October 2017 02:41 >> > As for mv88e6xxx, setup the switch from within the mv88e6060 driver with >> > a random MAC address, and remove the .set_addr implementation. >> > >> > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> >> > --- >> > drivers/net/dsa/mv88e6060.c | 30 +++++++++++++++++++----------- >> > 1 file changed, 19 insertions(+), 11 deletions(-) >> > >> > diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c >> > index 621cdc46ad81..2f9d5e6a0f97 100644 >> > --- a/drivers/net/dsa/mv88e6060.c >> > +++ b/drivers/net/dsa/mv88e6060.c >> ... >> > + REG_WRITE(REG_GLOBAL, GLOBAL_MAC_01, (addr[0] << 9) | >> addr[1]); >> >> Is that supposed to be 9 ? > > Looks like it. > Check > http://www.marvell.com/switching/assets/marvell_linkstreet_88E6060_datasheet.pdf Hum, David is correct, there is a bug in the driver which needs to be addressed first. MAC address bit 40 is addr[0] & 0x1, thus we must shift byte 0 by 8 and mask it against 0xfe. I'll respin this serie including a fix for both net and net-next. Thanks, Vivien
