On Wed, Oct 11, 2017 at 7:50 AM, Roman Mashak <m...@mojatatu.com> wrote:
> Macro __stringify_1() can stringify a macro argument, however IFE_META_*
> are enums, so they never expand, however request_module expects an integer
> in IFE module name, so as a result it always fails to auto-load.
>
> Fixes: ef6980b6becb ("introduce IFE action")
> Signed-off-by: Roman Mashak <m...@mojatatu.com>

Good catch!

Alternatively, it seems we can also do this:

...
#define _IFE_META_PRIO 3

enum {
...
        IFE_META_PRIO = _IFE_META_PRIO,
...
};



#define MODULE_ALIAS_IFE_META(metan)   MODULE_ALIAS("ifemeta" ##_
__stringify_1(metan))

But it does _not_ look any better than yours.

So,

Acked-by: Cong Wang <xiyou.wangc...@gmail.com>

Reply via email to