On Tue, Oct 03, 2017 at 08:24:06PM -0700, Eric Dumazet wrote: > On Tue, 2017-10-03 at 19:52 -0700, Alexei Starovoitov wrote: > > > yep. looks great. > > Please test it and submit officially :) > > The commit aafe6ae9cee3 ("bpf: dynamically allocate digest scratch buffer") > > fixed the other case where we were relying on the above mutex. > > The only other spot to be adjusted is to add spin_lock/mutex or DO_ONCE() to > > bpf_get_skb_set_tunnel_proto() to protect md_dst init. > > imo that would be it. > > Daniel, anything else comes to mind? > > > 16 MB of log (unswappable kernel memory) per active checker. > > We might offer a way to oom hosts.
right. good point! we need to switch to continuous copy_to_user() after a page or so. Can even do it after every vscnprintf() but page at a time is probably faster.