From: Andrew Lunn <and...@lunn.ch> Date: Mon, 2 Oct 2017 23:57:23 +0200
> On Mon, Oct 02, 2017 at 03:31:39PM -0500, John Allen wrote: >> The vnic server can report -1 in the event that a given statistic is not >> supported. Currently, the -1 value is implicitly cast to an unsigned >> integer and appears through the ethtool -S output as a very large number. >> This patch improves this behavior by reporting 0 in the event that a >> given statistic is not supported. > > Hi John > > If it does not exist, why not skip it altogether? > ibmvnic_get_sset_count() could walk the list and count the valid ones. > ibmvnic_get_strings() could only return the name of the valid onces. Agreed, skipping would be preferable to printing zero values.
