On Wed, Sep 27, 2017 at 12:33:29PM -0700, Florian Fainelli wrote: > On 09/27/2017 12:19 PM, Vivien Didelot wrote: > > Hi Andrew, Florian, > > > > Andrew Lunn <and...@lunn.ch> writes: > > > >> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING > >> enabled. Any change to enable hardware flooding needs careful testing > >> for lots of different configurations. This is another reason i don't > >> want to do it at the DSA level, until we have a good understanding > >> what it means in each individual driver. > > > > Then if we are worried about how broadcast flooding is handled on > > different switches, we can provide a new .flood_broadcast(ds, vid) > > switch operation for the drivers to implement. > > We don't really have a good visibility on the number of switches > requiring special configuration for broadcast addresses nor how this > would have to happen so it would be a tad difficult to define an > appropriate API with a single user.
Yes, i agree with this. We should wait before adding a generic solution. I want to wait until a few drivers do whatever is needed for hardware broadcast. We can then see what is common, and what is different, find an API to suit and do some refactoring. Andrew