On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > + > > > + length = nsh_hdr_len(nsh_hdr); > > > + skb_pull(skb, length); > > > > Do you need to verify you can actually pull length bytes? I don't see > > any guarantee. > > I have added skb length check in pop_nsh, so that can verify this.
That doesn't help other code that may call skb_pop_nsh(). skb_vlan_pop() calls skb_ensure_writable() which seems like the right thing to do.
