On 09/09/17 13:29, Nikolay Aleksandrov wrote: > On 09/09/17 02:54, Mahesh Bandewar (महेश बंडेवार) wrote: >> On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov >> <niko...@cumulusnetworks.com> wrote: >>> On 08/09/17 17:17, Kosuke Tatsukawa wrote: [snip] >>> >> I think the underlying issue is that tlb_dynamic_lb should be set to 1 >> for all modes which was not the case when it was getting initialized >> only forTLB mode. So from that perspective I prefer Nik's patch with a >> small variation that guards the case when mode transitions from TLB to >> ALB. The reason why I like that patch is because it's simple and >> avoids complications. > > +1, I think this is the most straight-forward solution as well and > safest for -net > > I will go ahead and submit it in a few minutes. > > Thanks, > Nik >
Just FYI, since the second fix (tlb_dynamic_lb in TLB = 0 switch to ALB) is identical to this patch, I'm acking this one and will wait until it's in to submit the default value fix (if we start in non-TLB mode and switch to TLB we'll get dynamic_lb = 0 currently). I guess this is the simplest way, I didn't want to alter user-configured value on mode switch, but it seems better than the alternative especially for -net.
