2017-08-31, 18:11:41 +0200, Stefano Brivio wrote: > After ip_route_input() calls ip_route_input_noref(), another > check on skb_dst() is done, but if this fails, we shouldn't > override the return code from ip_route_input_noref(), as it > could have been more specific (i.e. -EHOSTUNREACH). > > This also saves one call to skb_dst_force_safe() and one to > skb_dst() in case the ip_route_input_noref() check fails. > > Reported-by: Sabrina Dubroca <sdubr...@redhat.com> > Fixes: ad65a2f05695 ("ipv4: call dst_hold_safe() properly")
That should be instead: Fixes: 9df16efadd2a ("ipv4: call dst_hold_safe() properly") Acked-by: Sabrina Dubroca <s...@queasysnail.net> -- Sabrina