On Wed, Aug 30, 2017 at 3:45 PM, Daniel Borkmann <dan...@iogearbox.net> wrote:
> On 08/31/2017 12:22 AM, Daniel Borkmann wrote:
>>
>> The prog->res.classid is the default one, but can be overridden
>> later depending on the specified program. cls_bpf_classify() does
>> after prog return (filter_res holds return code):
>>
>> [...]
>> if (filter_res == 0)
>> continue;
>> if (filter_res != -1) {
>> res->class = 0;
>> res->classid = filter_res;
>> } else {
>> *res = prog->res;
>> }
>> [...]
>>
>> Meaning in case of a match (-1), we use the default bound one,
>> but prog may as well return an alternative found classid if it
>> wants to. So both versions are possible.
>
>
> But even for that case your patch looks fine to me actually, since
> for dynamic classid we set class to 0. No objections from my side
> then.
Sounds good. Then I will leave it as it is.
Thanks for explanation.
