On 08/29/2017 02:15 PM, Pavel Machek wrote: > On Tue 2017-08-29 14:26:04, Andrew Lunn wrote: >>> But the MDIO emaulation code is from their driver, after lots of >>> deletions. >> >> Is this driver supposed to run on lots of different OSs? That would >> explain why they ignored the Linux MDIO and PHY layers. > > It did not look particulary portable.
Part of the problem is that they need to duplicate the standard MII definitions, whereas we could re-use those from include/linux/mii.h and/or mdio.h. > >> If possible, please make use of the Linux infrastructure. > > I did not find any infrastructure I could use instead > ksz_mdio_emulation. fixed PHY/swphy.c is as close as it could get, but it is a highly simplified version of this. > > Now, drivers/net/phy/spi_ks8995.c can access the PHY registers, and I > can not see any translation there, so there may be something I'm > missing. I don't see anything in that driver that seems to access PHY registers what makes you think it does? There's got to be a way to perform indirect accesses through SPI, Woojung, do you know? > > Pointers would be welcome at this point. > > Thanks, > Pavel > -- Florian
