From: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Date: Mon, 28 Aug 2017 15:17:38 -0400
> This patch series adds a generic debugfs interface for the DSA > framework, so that all switch devices benefit from it, e.g. Marvell, > Broadcom, Microchip or any other DSA driver. I've been thinking this over and I agree with the feedback given that debugfs really isn't appropriate for this. Please create a DSA device class, and hang these values under appropriate sysfs device nodes that can be easily found via /sys/class/dsa/ just as easily as they would be /sys/kernel/debug/dsa/ You really intend these values to be consistent across DSA devices, and you don't intend to go willy-nilly changig these exported values arbitrarily over time. That's what debugfs is for, throw-away stuff. So please make these proper device sysfs attributes rather than debugfs. Thank you.
