On 08/28/2017 12:50 PM, Jiri Pirko wrote: > Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >> This commit adds a DEBUG_FS dependent DSA core file creating a generic >> debug filesystem interface for the DSA switch devices. >> >> The interface can be mounted with: >> >> # mount -t debugfs none /sys/kernel/debug >> >> The dsa directory contains one directory per switch chip: >> >> # cd /sys/kernel/debug/dsa/ >> # ls >> switch0 switch1 switch2 >> >> Each chip directory contains one directory per port: >> >> # ls -l switch0/ >> drwxr-xr-x 2 root root 0 Jan 1 00:00 port0 >> drwxr-xr-x 2 root root 0 Jan 1 00:00 port1 >> drwxr-xr-x 2 root root 0 Jan 1 00:00 port2 >> drwxr-xr-x 2 root root 0 Jan 1 00:00 port5 >> drwxr-xr-x 2 root root 0 Jan 1 00:00 port6 >> >> Future patches will add entry files to these directories. >> >> Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > > Oh no, no debugfs please! > > What do you need to expose? I'm sure we can find out some generic, well > defined and reusable way.
We have no CPU or DSA (cross switches) net_device reprensentors because those would be two ends of the same pipe so it would be both confusing and a duplication. For a CPU interface, one side goes to the switch, the other one is the master net_device (normal Ethernet MAC). For a DSA interface, one interface is on one switch, and the other is on the other switch. If you look at the patch series it's pretty obvious what is being exposed :) -- Florian
