Hi Andrew, On Fri, Aug 25, 2017 at 05:51:11PM +0200, Andrew Lunn wrote: > > - Checked if the carrier_on/off functions were needed. They are. > > Could you explain the situations they are needed in? > > Quite a few drivers do this, so i'm not saying it is wrong. But it > would be nice to understand if we are missing something in phylib.
I know it's not working without these calls, but I can't tell why (yet). I can try to dig into this. Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature