On 08/24/2017 10:26 PM, David Ahern wrote: > On 8/23/17 11:40 PM, Jiri Pirko wrote: >> +static int >> +mlxsw_sp_dpipe_table_host_entries_get(struct mlxsw_sp *mlxsw_sp, >> + struct devlink_dpipe_entry *entry, >> + bool counters_enabled, >> + struct devlink_dpipe_dump_ctx *dump_ctx, >> + int type) >> +{ >> + int rif_neigh_count = 0; >> + int rif_neigh_skip = 0; >> + int neigh_count = 0; >> + int rif_count; >> + int i, j; >> + int err; >> + >> + rtnl_lock(); > > Why does a h/w driver dumping its tables need the rtnl lock? >
This table represents the hw IPv4 arp table, and the driver depends on rtnl to be held.