On Thu, Aug 24, 2017 at 07:14:18PM +0200, Antoine Tenart wrote: > On Thu, Aug 24, 2017 at 05:08:29PM +0000, Stefan Chulski wrote: > > > > Imagine phylib is using the copper Ethernet PHY, but the MAC is using > > > > the SFP port. Somebody pulls out the copper cable, phylib says the > > > > link is down, turns the carrier off and calls the callback. Not good, > > > > since your SFP cable is still plugged in... Ethtool is > > > > returning/setting stuff in the Copper Ethernet PHY, when in fact you > > > > intend to be setting SFP settings. > > > > > > I see what could be the issue but I do not understand one aspect though: > > > how could we switch from one PHY to another, as there's only one output > > > between the SoC (and so a given GoP#) and the board. So if a given PHY can > > > handle multiple modes I see, but in the other case a muxing somewhere > > > would > > > be needed? Or did I miss something? > > > > I think PHY name and PHY mode struct that describe here both MAC to > > PHY and PHY to PHY connection create confusion... Serdes IP lane > > doesn't care if connector is SFP, RJ45 or direct attached cable. > > mvpp22_comphy_init only configures MAC to PHY > > connection. SFI for 10G(KR in mainline), SGMII for 1G and HS_SGMII for > > 2.5G. > > So maybe one confusion was to name them PHY_MODE_10GKR and > PHY_MODE_SGMII. It could be PHY_MODE_10G and PHY_MODE_1G instead.
SGMII mode supports 100M and 10M as well using data repetition, so 1G makes it look like those speeds are not supported. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
