> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 23, 2017 7:47 AM > To: Madalin-cristian Bucur <madalin.bu...@nxp.com> > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen > > From: Madalin-cristian Bucur <madalin.bu...@nxp.com> > Date: Wed, 23 Aug 2017 04:36:56 +0000 > > > The struct fman is only visible in the fman file, the fman port > > module uses struct fman as an opaque pointer, thus this export. > > Don't use that programming model. > > Export the datastructure properly to it's users. > > This abstraction scheme is so wasteful and costly.
Normally does not come with this cost, it's this case where one of the sub-modules needs to call into another that gets things complicated. I'll move struct fman to the header file. Thanks, Madalin
