On Tue, Aug 22, 2017 at 5:08 PM, Mike Maloney <maloneyker...@gmail.com> wrote: > From: Mike Maloney <malo...@google.com> > > Validate the behavior of the combination of various timestamp socket > options, and ensure consistency across ip, udp, and tcp. > > Signed-off-by: Mike Maloney <malo...@google.com>
Acked-by: Willem de Bruijn <will...@google.com> Thanks for adding these tests. For tcp, it may be useful to eventually also add packetdrill tests to validate the more subtle semantics, such as that the timestamp is returned only when reading the last byte of the skb. > + do_send(src); > + > + if (s.type == SOCK_RAW) > + read_size += 20; /* for IP header */ No need to revise just for this, but if submitting a v3: please use sizeof(struct iphdr). And maybe test PF_INET6, too.
