On Mon, 21 Aug 2017 09:42:27 +0000, Jan Scheurich wrote: > I understand your concern. But not declaring md2 as array is wrong as > well, as there might not be an MD2 TLV context header. An MD2 NSH > header is perfectly valid without any TLV. So in any case the user of > the struct needs to be aware of the NSH semantics.
Good point. > NSH can be carried over Ethernet with a 14 byte header. In that case > the total NSH header would typically be 16-bit aligned, so that all > 32-bit members would be misaligned. See NET_IP_ALIGN in include/linux/skbuff.h. Jiri