On Fri, 11 Aug 2017 10:09:36 +0000, Jan Scheurich wrote: > Unless someone can explain to me why the datapath should understand the > internal structure/format of metadata in push_nsh, I would strongly > vote to keep the metadata as variable length octet sequence in the > non-structured OVS_ACTION_ATTR_PUSH_NSH
Could be but it still needs to be in a different attribute and not in the ovs_action_push_nsh structure. Separate attributes for MD1/MD2 has the advantage of easier validation: with a separate MD1 type attribute, the size check is easier. With an unstructured MD attribute, we'd need to look into the OVS_ACTION_ATTR_NSH_BASE_HEADER attribute for mdtype and then validate the unstructured MD attribute size manually. Not a big deal, though. I don't have strong opinion here. But I do have strong opinion that MD needs to go into a separate attribute, whether there are separate attributes for MD1/2 or not. Jiri
