On Mon, Jul 31, 2017 at 03:19:21PM -0700, Shaohua Li wrote: > From: Shaohua Li <s...@fb.com> > > Please see below tcpdump output: > 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, > options [mss 65476,sackOK,TS val 2500903437 ecr 0,nop,wscale 7], length 0 > 21:00:48.109381 IP6 (flowlabel 0xd827f, hlim 64, next-header TCP (6) payload > length: 40) fec0::5054:ff:fe12:3456.5555 > fec0::5054:ff:fe12:3456.55804: > Flags [S.], cksum 0x0529 (incorrect -> 0x49ad), seq 1923801573, ack > 3282214509, win 43690, options [mss 65476,sackOK,TS val 2500903437 ecr > 2500903437,nop,wscale 7], length 0 > 21:00:48.109548 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 32) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [.], cksum 0x0521 (incorrect -> 0x1bdf), seq 1, ack 1, win 342, options > [nop,nop,TS val 2500903437 ecr 2500903437], length 0 > 21:00:48.109823 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 62) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [P.], cksum 0x053f (incorrect -> 0xb8b1), seq 1:31, ack 1, win 342, > options [nop,nop,TS val 2500903437 ecr 2500903437], length 30 > 21:00:48.109910 IP6 (flowlabel 0xd827f, hlim 64, next-header TCP (6) payload > length: 32) fec0::5054:ff:fe12:3456.5555 > fec0::5054:ff:fe12:3456.55804: > Flags [.], cksum 0x0521 (incorrect -> 0x1bc1), seq 1, ack 31, win 342, > options [nop,nop,TS val 2500903437 ecr 2500903437], length 0 > 21:00:48.110043 IP6 (flowlabel 0xd827f, hlim 64, next-header TCP (6) payload > length: 56) fec0::5054:ff:fe12:3456.5555 > fec0::5054:ff:fe12:3456.55804: > Flags [P.], cksum 0x0539 (incorrect -> 0xb726), seq 1:25, ack 31, win 342, > options [nop,nop,TS val 2500903438 ecr 2500903437], length 24 > 21:00:48.110173 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 32) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [.], cksum 0x0521 (incorrect -> 0x1ba7), seq 31, ack 25, win 342, > options [nop,nop,TS val 2500903438 ecr 2500903438], length 0 > 21:00:48.110211 IP6 (flowlabel 0xd827f, hlim 64, next-header TCP (6) payload > length: 32) fec0::5054:ff:fe12:3456.5555 > fec0::5054:ff:fe12:3456.55804: > Flags [F.], cksum 0x0521 (incorrect -> 0x1ba7), seq 25, ack 31, win 342, > options [nop,nop,TS val 2500903438 ecr 2500903437], length 0 > 21:00:48.151099 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 32) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [.], cksum 0x0521 (incorrect -> 0x1ba6), seq 31, ack 26, win 342, > options [nop,nop,TS val 2500903438 ecr 2500903438], length 0 > 21:00:49.110524 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload > length: 56) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.5555: > Flags [P.], cksum 0x0539 (incorrect -> 0xb324), seq 31:55, ack 26, win 342, > options [nop,nop,TS val 2500904438 ecr 2500903438], length 24 > 21:00:49.110637 IP6 (flowlabel 0xb34d5, hlim 64, next-header TCP (6) payload > length: 20) fec0::5054:ff:fe12:3456.5555 > fec0::5054:ff:fe12:3456.55804: > Flags [R], cksum 0x0515 (incorrect -> 0x668c), seq 1923801599, win 0, length 0 > > The flowlabel of reset packet (0xb34d5) and flowlabel of normal packet > (0xd827f) are different. This causes our router doesn't correctly close tcp > connection. The patches try to fix the issue.
Hi Dave, Could you please look at the patches? Thanks, Shaohua > > Thanks, > Shaohua > > Shaohua Li (2): > net: remove unnecessary rotation > net: fix tcp reset packet flowlabel for ipv6 > > include/net/ipv6.h | 15 ++++----------- > net/ipv4/tcp_minisocks.c | 8 +++++++- > net/ipv6/ip6_gre.c | 2 +- > net/ipv6/ip6_output.c | 4 ++-- > net/ipv6/ip6_tunnel.c | 2 +- > net/ipv6/tcp_ipv6.c | 18 +++++++++++++++++- > 6 files changed, 32 insertions(+), 17 deletions(-) > > -- > 2.9.3 >
