On Tue, Jul 25, 2017 at 9:44 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote:
> Commit de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> moves link status commitment into bond_mii_monitor(), but it still relies
> on the return value of bond_miimon_inspect() as the hint. We need to return
> non-zero as long as we propose a link status change.
>
> Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> Reported-by: Benjamin Gilbert <benjamin.gilb...@coreos.com>
> Tested-by: Benjamin Gilbert <benjamin.gilb...@coreos.com>
> Cc: Mahesh Bandewar <mahe...@google.com>
> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Mahesh Bandewar <mahe...@google.com>
> ---
> drivers/net/bonding/bond_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 181839d6fbea..9bee6c1c70cc 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2050,6 +2050,7 @@ static int bond_miimon_inspect(struct bonding *bond)
> continue;
>
> bond_propose_link_state(slave, BOND_LINK_FAIL);
> + commit++;
> slave->delay = bond->params.downdelay;
> if (slave->delay) {
> netdev_info(bond->dev, "link status down for
> %sinterface %s, disabling it in %d ms\n",
> @@ -2088,6 +2089,7 @@ static int bond_miimon_inspect(struct bonding *bond)
> continue;
>
> bond_propose_link_state(slave, BOND_LINK_BACK);
> + commit++;
> slave->delay = bond->params.updelay;
>
> if (slave->delay) {
> --
> 2.13.0
>
