On 07/18/2017 03:52 PM, Fabio Estevam wrote:
Won't this result in kernel WARNING when GPIO is disabled?
GPIO support, I was going to type...
Not sure if I understood your point, but gpiod_set_value_cansleep() is
a no-op when the gpiod is NULL.
Look at the stub in <linux/gpio/consumer.h>, it has WARN_ON(1).
This patch does not alter the behavior of the driver with respect to
GPIO being disabled,
No, it does -- devm_gpiod_get_optinal() will return NULL in that case,
bus->reset_gpio will remanin NULL, and you're removing the NULL checks around
the gpiod_set_value_cansleep() calls. Perhaps it's the problem in the GPIO
support though...
so I still do not understand your concern.
And now?
MBR, Sergei
