On Mon, 2017-07-17 at 15:38 +0200, Andrew Lunn wrote: > On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang <sean.w...@mediatek.com> > > > > The patch adds the supplements in the dt-binding document for MediaTek > > MT7622 SoC with extra SGMII system controller and relevant clock consumers > > listed as the requirements for those SoCs equipped with the SGMII circuit. > > Also, add the missing binding information for MT7623 SoC here which relies > > on the fallback binding of MT2701. > > > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > > --- > > Documentation/devicetree/bindings/net/mediatek-net.txt | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt > > b/Documentation/devicetree/bindings/net/mediatek-net.txt > > index c7194e8..1d1168b 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > > @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. > > * Ethernet controller node > > > > Required properties: > > -- compatible: Should be "mediatek,mt2701-eth" > > +- compatible: Should be > > + "mediatek,mt2701-eth": for MT2701 SoC > > + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC > > Hi Sean > > We appear to have "mediatek,mt2701-eth" twice. >
Hi, Andrew mt7623-eth supported up to now currently rely on the fallback binding of mt2701-eth in fact, the logic could be commonly found in many driver such as mtk sysirq such as [1] did, so i felt this usage should not make something wrong. [1] https://patchwork.kernel.org/patch/9739827/ > Andrew
