> +/** > + * get_dev_cap - get device capabilities > + * @hwdev: the NIC HW device to get capabilities for > + * > + * Return 0 - Success, negative - Failure > + **/ > +static int get_dev_cap(struct hinic_hwdev *hwdev) > +{ > + struct hinic_pfhwdev *pfhwdev; > + struct hinic_hwif *hwif = hwdev->hwif; > + struct pci_dev *pdev = hwif->pdev; > + int err; > + > + switch (HINIC_FUNC_TYPE(hwif)) { > + case HINIC_PPF: > + case HINIC_PF: > + pfhwdev = container_of(hwdev, struct hinic_pfhwdev, hwdev); > + > + err = get_cap_from_fw(pfhwdev); > + if (err) { > + dev_err(&pdev->dev, "Failed to get capability from > FW\n"); > + return err; > + } > + break; > + > + default: > + pr_err("Unsupported PCI Function type\n");
Hi Aviad more pr_err(). Please go through all the patches and use dev_err(), or netif_err() if appropriate. Thanks Andrew