On Thu, Jun 29, 2017 at 06:21:53PM +0300, Or Gerlitz wrote:
> On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman
> <simon.hor...@netronome.com> wrote:
> > +++ b/drivers/net/ethernet/netronome/nfp/flower/cmsg.h
> > @@ -245,7 +245,11 @@ struct nfp_flower_cmsg_hdr {
> >
> > /* Types defined for port related control messages */
> > enum nfp_flower_cmsg_type_port {
> > + NFP_FLOWER_CMSG_TYPE_FLOW_ADD = 0,
> > + NFP_FLOWER_CMSG_TYPE_FLOW_MOD = 1,
>
> AFAIU flower offload will always use delete and add and not modify,
> if you think otherwise, would love to hear that. Didn't see you are using
> the MOD define in the code anywhere.
The firmware API has a mod operation but you are correct that
we are not implementing that operation in this patch-set.
