On Thu, Jun 29, 2017 at 05:39:34PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Previously there was no way of updating flow rule stats after they > > have been offloaded to hardware. This is solved by keeping track of > > stats received from hardware and providing this to the TC handler > > on request. > > > You are using the term/variable "unmasked_data" across the code, to > make it clear > the keys provided to the driver are masked by the tcflower kernel code > [1] - what do > you mean by unmasked data? > > Or. > > [1] f93bd17 net/sched: cls_flower: Use masked key when calling HW offloads
>From a firmware point of view there is an unmasked key and a mask. These are referred to as unmasked_data and mask_data although in TC supplies a masked key which the firmware can also handle.