On Wed, Jun 28, 2017 at 06:53:40PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 22:29:56 +0200, Simon Horman wrote: > > +/** > > + * nfp_flower_del_offload() - Removes a flow from hardware. > > + * @app: Pointer to the APP handle > > + * @netdev: netdev structure. > > + * @flow: TC flower classifier offload structure > > Nit: there are spaces and tabs mixed here, same for > nfp_flower_get_stats().
Thanks for noticing that, we'll fix it. > > + * > > + * Removes a flow from the repeated hash structure and clears the > > + * action payload. > > + * > > + * Return: negative value on error, 0 if removed successfully. > > + */ > > +static int > > +nfp_flower_del_offload(struct nfp_app *app, struct net_device *netdev, > > + struct tc_cls_flower_offload *flow) > > +{ > > + return -EOPNOTSUPP; > > +} >